Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Privacy Text Option to CTAs #12293

Merged
merged 20 commits into from
May 31, 2024

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented May 1, 2024

Description

This PR adds a field to CTAs to overwrite the default privacy notice. This new field will allow users to A/B test custom privacy text vs. the default privacy text on various signups or petitions.

When this field is set, it will display instead of the default privacy notice. When this field is empty (as by default), the default privacy text will display.

Link to sample test page:
Related PRs/issues: #12169 / TP1-394

Credentials:
username: admin
password: W5YO6CFsu0$98!ch

To Test

  1. Log in to review app via https://foundation-s-tp1-394-12-7kcnly.herokuapp.com/cms/ (see credentials above)
  2. Navigate to https://foundation-s-tp1-394-12-7kcnly.herokuapp.com/en/campaigns/century-interview-plan/
  3. Note the default privacy text
  4. Edit this page
  5. Click on the ... actions to edit the Cta
  6. Note the new field for Privacy Notice and the help text
  7. Add in a new Privacy Notice, and be sure to include a link within the richtext field by highlighting some text.
  8. Review the campaign page again: https://foundation-s-tp1-394-12-7kcnly.herokuapp.com/en/campaigns/century-interview-plan/
  9. Note the custom Privacy Notice is now showing

Checklist

Tests
- [ ] Is the code I'm adding covered by tests?

Changes in Models:
- [ ] Did I update or add new fake data?
- [ ] Did I squash my migration?

  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:
- [ ] Is my code documented?
- [ ] Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-394-12-7kcnly May 1, 2024 20:28 Inactive
@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-394-12-7kcnly May 1, 2024 20:32 Inactive
@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-394-12-7kcnly May 1, 2024 21:21 Inactive
@robdivincenzo robdivincenzo requested a review from mmmavis May 1, 2024 21:36
@mmmavis
Copy link
Collaborator

mmmavis commented May 13, 2024

Sorry for the delay. I will review this PR today.

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay we are almost ready to enable A/B test for newsletter signup form! I've left some inline comments, please let me know what you think! After searching for all instances of newsletter-signup-module, I've also noticed there are a few instances missing the data-cta-privacy-notice attribute. For example, in bannered_campaign_page.html around line 65, network-api/networkapi/templates/fragments/primary_nav.html around line 85, and maybe some more. Could we please add the attribute to those places? Thanks!

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-394-12-kjahhg May 15, 2024 14:42 Inactive
@robdivincenzo
Copy link
Collaborator Author

Thanks for the review and feedback @mmmavis! PR should be up-to-date.

@robdivincenzo robdivincenzo requested a review from mmmavis May 29, 2024 18:05
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robdivincenzo R+! Awesome work! Before you merge this PR, could you please add a note at the top of wagtailpages/fragments/formassembly_body.html about the changes you applied to the privacy field? Thank you.

@robdivincenzo robdivincenzo merged commit fcb5f03 into main May 31, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants